Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable ModelVersion #1708

Merged
merged 11 commits into from
Mar 25, 2024
Merged

disable ModelVersion #1708

merged 11 commits into from
Mar 25, 2024

Conversation

szysad
Copy link
Contributor

@szysad szysad commented Mar 25, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@szysad szysad changed the base branch from master to dev/2.0 March 25, 2024 11:08
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.25%. Comparing base (d1be412) to head (6df8ce9).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/2.0    #1708      +/-   ##
===========================================
+ Coverage    72.03%   73.25%   +1.21%     
===========================================
  Files          336      336              
  Lines        16494    16630     +136     
===========================================
+ Hits         11882    12182     +300     
+ Misses        4612     4448     -164     
Flag Coverage Δ
e2e 54.45% <0.00%> (?)
e2e-management 55.61% <0.00%> (?)
e2e-s3 54.32% <0.00%> (?)
e2e-s3-gcs 52.30% <0.00%> (?)
macos 68.00% <100.00%> (-6.40%) ⬇️
py3.12 57.25% <0.00%> (?)
py3.7 68.41% <100.00%> (-6.04%) ⬇️
py3.7.16 51.84% <0.00%> (?)
ubuntu 75.44% <100.00%> (+1.05%) ⬆️
unit 73.97% <100.00%> (-0.48%) ⬇️
windows 67.83% <100.00%> (-5.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szysad
Copy link
Contributor Author

szysad commented Mar 25, 2024

E2E

@szysad szysad changed the title Ss/disable model versions disable ModelVersion Mar 25, 2024
@szysad
Copy link
Contributor Author

szysad commented Mar 25, 2024

E2E

@szysad szysad marked this pull request as ready for review March 25, 2024 14:59
@szysad szysad merged commit 4f79c34 into dev/2.0 Mar 25, 2024
20 of 28 checks passed
@szysad szysad deleted the ss/disable-model-versions branch March 25, 2024 15:05
Raalsky pushed a commit that referenced this pull request Mar 25, 2024
Co-authored-by: Szymon Sadkowski <szymon.sadkowski@neptune.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants