Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable neptune model #1701

Merged
merged 11 commits into from
Mar 25, 2024
Merged

disable neptune model #1701

merged 11 commits into from
Mar 25, 2024

Conversation

szysad
Copy link
Contributor

@szysad szysad commented Mar 19, 2024 •
edited
Loading

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@szysad szysad requested review from normandy7 and removed request for normandy7 March 19, 2024 12:14
@codecov Codecov
Copy link

codecov bot commented Mar 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.31%. Comparing base (9785399) to head (236528d).
Report is 1 commits behind head on dev/2.0.

Additional details and impacted files 
@@             Coverage Diff             @@
##           dev/2.0    #1701      +/-   ##
===========================================
+ Coverage    74.10%   77.31%   +3.20%     
===========================================
  Files          336      336              
  Lines        16477    16616     +139     
===========================================
+ Hits         12211    12847     +636     
+ Misses        4266     3769     -497
Flag Coverage Δ
macos 76.62% <100.00%> (-0.35%) ⬇️
py3.7 76.40% <100.00%> (-0.81%) ⬇️
ubuntu 76.40% <100.00%> (-0.67%) ⬇️
unit 76.40% <100.00%> (-0.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szysad
Copy link
Contributor Author

szysad commented Mar 19, 2024 •
edited
Loading

💀 E2E

@szysad szysad requested a review from normandy7 March 19, 2024 12:33
@szysad
Copy link
Contributor Author

szysad commented Mar 20, 2024 •
edited
Loading

💀 E2E

@szysad
Copy link
Contributor Author

szysad commented Mar 20, 2024 •
edited
Loading

💀 E2E

@szysad
Copy link
Contributor Author

szysad commented Mar 20, 2024 •
edited
Loading

💀 E2E

@szysad
Copy link
Contributor Author

szysad commented Mar 20, 2024 •
edited
Loading

💀 E2E

@szysad
Copy link
Contributor Author

szysad commented Mar 20, 2024 •
edited
Loading

✅ E2E

@szysad szysad marked this pull request as ready for review March 20, 2024 19:50
@szysad @normandy7
Update src/neptune/exceptions.py
236528d 
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
@szysad szysad merged commit d1be412 into dev/2.0 Mar 25, 2024
4 checks passed
@szysad szysad deleted the ss/disable-model branch March 25, 2024 14:22
Raalsky pushed a commit that referenced this pull request Mar 25, 2024
@szysad @normandy7 @Raalsky
disable neptune model (#1701)
2794755 
Co-authored-by: Szymon Sadkowski <szymon.sadkowski@neptune.ai>
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raalsky Raalsky Raalsky approved these changes

@normandy7 normandy7 normandy7 approved these changes

@AleksanderWWW AleksanderWWW Awaiting requested review from AleksanderWWW AleksanderWWW is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szysad @Raalsky @normandy7