tests: remove cleanup_func #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "vim" fixture uses a new session always. It was added when migrating to pytest in b65f62d, but is not really necessary. It could still be used to e.g. ensure tests are cleaning up after themselves, but this is also not necessary really. Adjusts existing tests, mainly with regard to handle IDs.
justinmk
reviewed
Oct 17, 2019
| @@ -9,50 +8,6 @@ | |||
| pynvim.setup_logging("test") | |||
|
|
|||
|
|
|||
| @pytest.fixture(autouse=True) | |||
| def cleanup_func(vim): | |||
There was a problem hiding this comment.
can we leave a stub here (with pass)?
There was a problem hiding this comment.
if I want to add setup code later it will be a pain to find out how. Stubs don't hurt anything.
Not a blocker though.
There was a problem hiding this comment.
Stubs at least get called all the time (not really that bad, but still).
Should be discoverable through the Git history I think.
(and if you're used to pytest you would know what you need anyway)
justinmk
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "vim" fixture uses a new session always.
It was added when migrating to pytest in b65f62d, but is not really
necessary. It could still be used to e.g. ensure tests are cleaning up
after themselves, but this is also not necessary really.
Adjusts existing tests, mainly with regard to handle IDs.