Check count for 'not None' instead of truthy in command decorator #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command decorator was only checking the truthyness of `count`, which meant that a value of 0 was considered falsy and so the value not passed to the decorated function. A value of 0 for `count` should be valid since this is the default in both vim and neovim (see `help v:count`).
|
Good catch. Can you add a test? |
This adds tests to ensure the appropriate functioning of the count option of the _nvim_rpc_spec when using the command decorator.
|
There are no other tests I could find for the decorators so I created a new file with the test case, I hope that is alright. |
bfredl
added a commit
that referenced
this pull request
Mar 1, 2018
In this release support of python3.3 is dropped. Henceforth we want python3
rplugins to be able to assume the usage of asyncio, so they can use the asyncio
event loop and libraries that build on it.
Furthermore, a close() method is added on nvim session objects. When used as
a library for externally connecting to a nvim instance (i e not rplugins),
it is recommended to call the close() method on the session object when it is
not needed anymore. Alternatively, sessions can be used as a context manager:
with neovim.attach('socket', path=thepath) as nvim:
# do stuff with nvim session in this block:
print(nvim.funcs.getpid())
print(nvim.current.line)
This will close the session automatically.
Changes since 0.2.1:
* 2689ddc add tests for plugin decorators #298
* 63f257f allow library users to properly cleanup the event loop #303
* 59c184f expose the asyncio event loop as nvim.loop (python 3.4+ only) #294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command decorator was only checking the truthyness of
count, whichmeant that a value of 0 was considered falsy and so the value not passed
to the decorated function. A value of 0 for
countshould be validsince this is the default in both vim and neovim (see
help v:count).