Fix failing tests on Windows.

[brcolow]

Test "test_vim.test_command" was failing because of the call to
os.unlink(..), as the file was still open in vim. Adding a conditional
to execute the call only if we are not running under Windows was the
most straight-forward "fix".

Test "test_vim.test_chdir" was failing for two reasons. Firstly because
of missing Windows-specific handling of path names in
find_file_in_path_option in file_search.c in Neovim core. Secondly
because although one can indeed :cd / on Windows (or at least, should
be able to), a corresponding call to :pwd will echo the root drive
of the current working directory of Neovim.

test_chdir should work now that neovim/neovim#4711 was merged.

[fwalch]

the file was still open in vim

What about adding vim.command('q') here, then?

[brcolow]

Tried it before posting the issue actually, didn't fix it =(

[equalsraf]

in the previous suggestion was for sending 'q', maybe that call to unlink is made before neovim actually shuts down. just for testing purposes try sleeping for a second before calling unlink just to be sure

[brcolow]

No amount of sleeping seems to have any affect..still results in error:

PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\brcolow\\AppData\\Local\\Temp\\tmp9zm0bm83'

[bfredl]

is this ready to merge?

[brcolow]

I think so...the question from @justinmk still remains about why the unlink doesn't work on Windows, and the suggestion by @fwalch about using vim.command('q') (which doesn't work)...in other words: this makes the tests pass, but I don't know if removing the unlink line will have any unintended consequences. The other test though (test_vim.test_chdir) is 👍. So just need a confirmation/decision about test_vim.test_command about removing the unlink call.

[justinmk]

@brcolow Try changing this so that the open()'d file gets closed before we try os.unlink() below. http://askubuntu.com/a/701536 Perhaps this:

with open(fname) as f:
    eq(f.read(), 'testing\npython\napi\n')

Then we shouldn't need to check os.name != 'nt' below.

[justinmk]

this line shouldn't be removed, otherwise there's no reason to make the change