Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Migrate to PHPStan for Flow 8 #3218

Merged
merged 10 commits into from
Nov 7, 2023
Merged

TASK: Migrate to PHPStan for Flow 8 #3218

merged 10 commits into from
Nov 7, 2023

Commits on Nov 7, 2023

  1. TASK: Add phpstan level 0 to Neos.Flow

    @mhsdesign
    mhsdesign committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    f7b87b1 View commit details
    Browse the repository at this point in the history

  2. TASK: Up phpstan to level 0 to all packages

    @mhsdesign
    mhsdesign committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    b562442 View commit details
    Browse the repository at this point in the history

  3. TASK: Up phpstan to level 1 in Neos.Flow

    @mhsdesign
    mhsdesign committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    8228f95 View commit details
    Browse the repository at this point in the history

  4. TASK: Up phpstan to level 1 to all packages

    @mhsdesign
    mhsdesign committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    645c853 View commit details
    Browse the repository at this point in the history

  5. TASK: use @phpstan-consistent-constructor instead of final constr… 

    …uctor

... as flows proxy building doesnt like it when on multiple level of inheritance:

Cannot override final method Neos\Flow\Security\Authentication\Provider\AbstractProvider::__construct() in /home/runner/work/flow-development-collection/flow-development-collection/flow-development-distribution/Data/Temporary/Testing/Cache/Code/Flow_Object_Classes/Neos_Flow_Security_Authentication_Provider_TestingProvider.php on line 130

see also https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static
    @mhsdesign
    mhsdesign committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    14109e7 View commit details
    Browse the repository at this point in the history

  6. TASK: Ignore error in likely dead code path

    @mhsdesign
    mhsdesign committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    e328e5a View commit details
    Browse the repository at this point in the history

  7. TASK: Fix AdvicedConstructorInterceptorBuilder 

    The method `buildMethodParametersCode` does not exist and most likely `$proxyMethod->buildMethodParametersCode` is meant.

> This dates back to Andi and I believe the solution is as simple as this being
> $proxyMethod->setMethodParametersCode($proxyMethod->buildMethodParametersCode($declaringClassName, $methodName, true));

> Which becomes even clearer looking at the sibling code in AdvicedMethodInterceptorBuilder where it is like I suggested

#3218 (comment)
    @mhsdesign
    mhsdesign committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    ee36c89 View commit details
    Browse the repository at this point in the history

  8. TASK: resource:clean abort if Neos.Media is not installed

    @mhsdesign
    mhsdesign committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    3e36081 View commit details
    Browse the repository at this point in the history

  9. TASK: Remove psalm from ci and run phpstan

    @mhsdesign
    mhsdesign committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    3ef9793 View commit details
    Browse the repository at this point in the history

  10. TASK: Remove psalm annotations and baseline

    @mhsdesign
    mhsdesign committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    31f5dff View commit details
    Browse the repository at this point in the history