Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

Add NeosDocumentImport family #280

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mpmxyz
Copy link
Contributor

@mpmxyz mpmxyz commented May 16, 2023

This time it is 3 mods in one repository to allow document import conversions:
1x library mod
2x miniature mods that register their conversion code using the library
PS: Visual Studio broke formatting while editing the JSON. -> pls squash the extra commits

@XDelta XDelta added the mod author PR Manifest additon made for your own mod label May 17, 2023
@XDelta
Copy link
Member

XDelta commented May 19, 2023

You do not need merge master branch after making the pr, unless you make actual changes to the pr afterwards, this will be done by the reviewer.

Copy link
Member

@ljoonal ljoonal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but think it'd make sense to separate the libs into their own entries like has been done with harmony...

@mpmxyz
Copy link
Contributor Author

mpmxyz commented May 22, 2023

I'm looking into it. It is inconvenient having to take care of transitive dependencies. Luckily it isn't many.
I'll probably use this opportunity to change to a pdfium binding that is receiving updates. (e.g. PdfLibCore)

@mpmxyz mpmxyz marked this pull request as draft May 22, 2023 19:39
@mpmxyz mpmxyz marked this pull request as ready for review May 25, 2023 22:51
@mpmxyz
Copy link
Contributor Author

mpmxyz commented May 25, 2023

I finished changing my project and fleshing out the manifest changes.
Now every external dll has it's own entry in the manifest.
I do not know how to get a url to dll files of NuGet packages. So I kept referencing to my own artifacts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
mod author PR Manifest additon made for your own mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants