Panic on receiving higher term #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arssher
reviewed
Jun 22, 2022
| if (sk->appendResponse.term > propTerm) | ||
| { | ||
| /* Another compute with higher term is running. */ | ||
| elog(PANIC, "WAL acceptor %s:%s with term " INT64_FORMAT " rejected our request, our term " INT64_FORMAT "", |
There was a problem hiding this comment.
We can also add safekeeper node id to the message.
There was a problem hiding this comment.
We have several ids in the logs currently, probably worth replacing all of them at once:
- index in the global
safekeepersarray - %s:%s address of the safekeeper
arssher
approved these changes
Jun 22, 2022
hlinnaka
added a commit
to neondatabase/neon
that referenced
this pull request
Jun 30, 2022
Contains changes from two PRs in vendor/postgres: - neondatabase/postgres#163 - neondatabase/postgres#176
hlinnaka
added a commit
to neondatabase/neon
that referenced
this pull request
Jul 5, 2022
Contains changes from two PRs in vendor/postgres: - neondatabase/postgres#163 - neondatabase/postgres#176
MMeent
pushed a commit
that referenced
this pull request
Jul 7, 2022
MMeent
pushed a commit
that referenced
this pull request
Aug 18, 2022
lubennikovaav
pushed a commit
that referenced
this pull request
Nov 21, 2022
MMeent
pushed a commit
that referenced
this pull request
Feb 10, 2023
MMeent
pushed a commit
that referenced
this pull request
Feb 10, 2023
MMeent
pushed a commit
that referenced
this pull request
May 11, 2023
tristan957
pushed a commit
that referenced
this pull request
Aug 10, 2023
tristan957
pushed a commit
that referenced
this pull request
Nov 8, 2023
tristan957
pushed a commit
that referenced
this pull request
Nov 8, 2023
tristan957
pushed a commit
that referenced
this pull request
Feb 5, 2024
tristan957
pushed a commit
that referenced
this pull request
Feb 5, 2024
tristan957
pushed a commit
that referenced
this pull request
Feb 6, 2024
tristan957
pushed a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
test_concurrent_computesfrom neondatabase/neon#1944