Skip to content

Commit

Permalink
[walproposer] Remove graceful termination of COPY during walproposer …
Browse files Browse the repository at this point in the history
…recovery.

Rust's postgres_backend currently is too dummy to handle it properly: reading
happens in separate thread which just ignores CopyDone. Instead, writer thread
must get aware of termination and send CommandComplete. Also reading socket must
be transferred back to postgres_backend (or connection terminated completely
after COPY). Let's do that after more basic safkeeper refactoring and right now
cover this up to make tests pass.

ref #388
  • Loading branch information
arssher authored and tristan957 committed May 10, 2024
1 parent d55d60c commit 9e0d321
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/backend/replication/walproposer.c
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,6 @@ WalProposerRecovery(int leader, TimeLineID timeline, XLogRecPtr startpos, XLogRe
if (rec_end_lsn >= endpos)
break;
}
walrcv_endstreaming(wrconn, &timeline);
walrcv_disconnect(wrconn);
}
else
Expand Down

0 comments on commit 9e0d321

Please sign in to comment.