Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: exclude triple logging of connect compute errors #9277

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Conversation

awarus
Copy link
Contributor

@awarus awarus commented Oct 4, 2024

Problem

Fixes #9020

Summary of changes

  • Use the compute::COULD_NOT_CONNECT for connection error message;
  • Eliminate logging for one connection attempt;
  • Typo fix.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

 - Use the compute::COULD_NOT_CONNECT for connection error message;
 - Eliminate logging for one connection attempt;
 - Typo fix.
@awarus awarus requested a review from a team as a code owner October 4, 2024 11:02
Copy link

github-actions bot commented Oct 4, 2024

5085 tests run: 4878 passed, 0 failed, 207 skipped (full report)


Flaky tests (5)

Postgres 17

Postgres 16

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 31.4% (7510 of 23916 functions)
  • lines: 49.6% (60289 of 121526 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
136e0a1 at 2024-10-04T13:14:32.054Z :recycle:

@awarus awarus merged commit 2d248ae into main Oct 4, 2024
79 checks passed
@awarus awarus deleted the logging-9020 branch October 4, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxy: triple logging of some errors
2 participants