safekeeper: skip syncfs on start if --no-sync is specified.

[arssher]

https://neondb.slack.com/archives/C059ZC138NR/p1727350911890989?thread_ts=1727350211.370869&cid=C059ZC138NR

[koivunej]

Looks good apart from the double negative on no-no-sync, but perhaps that is an too old mistake to be corrected here.

Cloud you link the PR to the internal thread on #cicd (and maybe on the merge commit as well)? Expectation is that we will have less transient startup failures caused by other concurrently running tests in ci, it would be great to note that as well in the PR+commit.

[github-actions]

5013 tests run: 4855 passed, 0 failed, 158 skipped (full report)

---

Flaky tests (5)

Postgres 17

• test_pageserver_compaction_smoke: release-arm64

Postgres 15

• test_ondemand_wal_download_in_replication_slot_funcs: release-x86-64
• test_location_conf_churn[3]: release-x86-64
• test_subscriber_restart: release-x86-64

Postgres 14

• test_gin_redo: release-arm64

Code coverage* (full report)

• functions: 32.0% (7495 of 23395 functions)
• lines: 50.1% (60499 of 120874 lines)

* collected from Rust tests only

---

_{The comment gets automatically updated with the latest test results
9d855eb at 2024-09-26T16:20:48.469Z :recycle:}

[arssher]

Cloud you link the PR to the internal thread on #cicd

The pr is actually triggered by this channel:
https://neondb.slack.com/archives/C059ZC138NR/p1727350911890989?thread_ts=1727350211.370869&cid=C059ZC138NR

[koivunej]

Cloud you link the PR to the internal thread on #cicd

The pr is actually triggered by this channel: https://neondb.slack.com/archives/C059ZC138NR/p1727350911890989?thread_ts=1727350211.370869&cid=C059ZC138NR

I cannot open that link for some reason, but I think I think I know what thread you are meaning to link :) I saw that, but did not comment anything.

I meant, could you link that thread from the PR description (currently empty) and the commit (currently empty) message?