Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: misc cleanup & fixes #8559

Merged
merged 6 commits into from
Aug 14, 2024
Merged

CI: misc cleanup & fixes #8559

merged 6 commits into from
Aug 14, 2024

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Jul 30, 2024

Problem

A bunch of small fixes and improvements for CI, that are too small to have a separate PR for them

Summary of changes

  • CI(build-and-test): fix parenthesis
  • CI(actionlint): fix path to workflow file
  • CI: remove default args from actions/checkout, see https://github.com/actions/checkout/tree/v4?tab=readme-ov-file#usage
  • CI: remove gen3 label, using a couple self-hosted + small{,-arm64}/large{,-arm64} is enough
  • CI: prettify Slack messages, hide links behind text messages
  • C(build-and-test): add more dependencies to conclusion job

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Jul 31, 2024

2156 tests run: 2087 passed, 0 failed, 69 skipped (full report)


Code coverage* (full report)

  • functions: 32.3% (7163 of 22173 functions)
  • lines: 50.3% (57935 of 115214 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
06b6de2 at 2024-08-14T13:06:29.420Z :recycle:

@bayandin bayandin changed the title CI: misc cleanup CI: misc cleanup & fixes Aug 11, 2024
@bayandin bayandin marked this pull request as ready for review August 11, 2024 14:06
Copy link
Contributor

@a-masterov a-masterov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bayandin bayandin merged commit aa2e16f into main Aug 14, 2024
67 checks passed
@bayandin bayandin deleted the bayandin/chore-ci-cleanup branch August 14, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants