Run each migration in its own transaction #8371
Merged
+54
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan957
force-pushed
the
tristan957/migrations
branch
4 times, most recently
from
0f82081
to
30b4e7c
Compare
3114 tests run: 2993 passed, 0 failed, 121 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
f9b99e2 at 2024-07-16T17:01:56.438Z :recycle: |
tristan957
force-pushed
the
tristan957/migrations
branch
2 times, most recently
from
f9f2525
to
ca7002c
Compare
save-buffer
approved these changes
Jul 15, 2024
ololobus
reviewed
Jul 16, 2024
This matches what we put into the neon_migration.migration_id table.
Previously, every migration was run in the same transaction. This is preparatory work for fixing CVE-2024-4317.
tristan957
force-pushed
the
tristan957/migrations
branch
from
ca7002c
to
f9b99e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, every migration was run in the same transaction. This is preparatory work for fixing CVE-2024-4317.
I've also renamed the migration files to match their actual migration ID number.