Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: remove obsolete cached_metric_collection_interval #8370

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

problame
Copy link
Contributor

@problame problame commented Jul 12, 2024

We're removing the usage of this long-meaningless config field in https://github.com/neondatabase/aws/pull/1599

Once that PR has been deployed to staging and prod, we can merge this PR.

@problame problame requested a review from koivunej July 12, 2024 17:35
Copy link

github-actions bot commented Jul 12, 2024

3126 tests run: 3005 passed, 0 failed, 121 skipped (full report)


Code coverage* (full report)

  • functions: 32.7% (6995 of 21385 functions)
  • lines: 50.2% (55226 of 110114 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
3f3ac1a at 2024-07-19T15:59:06.309Z :recycle:

@problame problame marked this pull request as ready for review July 19, 2024 15:10
@problame problame requested a review from a team as a code owner July 19, 2024 15:10
@problame problame requested review from arpad-m and removed request for arpad-m July 19, 2024 15:10
@problame problame enabled auto-merge (squash) July 19, 2024 15:11
@problame problame merged commit 16071e5 into main Jul 19, 2024
65 checks passed
@problame problame deleted the problame/remove-cached_metric_collection_interval branch July 19, 2024 16:01
problame added a commit that referenced this pull request Jul 22, 2024
We're removing the usage of this long-meaningless config field in
neondatabase/infra#1599

Once that PR has been deployed to staging and prod, we can merge this
PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants