Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): unique test harness name for merge_in_between #8366

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jul 12, 2024

Problem

As title, there should be a way to detect duplicated harness names in the future :(

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from jcsp July 12, 2024 12:37
@skyzh skyzh marked this pull request as ready for review July 12, 2024 12:37
@skyzh skyzh requested a review from a team as a code owner July 12, 2024 12:37
@skyzh skyzh enabled auto-merge (squash) July 12, 2024 12:37
@jcsp
Copy link
Contributor

jcsp commented Jul 12, 2024

I would be fine with making TenantHarness generate a pseudorandom path in future, this business of hardcoding test names is too error prone

@skyzh skyzh merged commit 4184685 into main Jul 12, 2024
62 checks passed
@skyzh skyzh deleted the skyzh/test-harness-name branch July 12, 2024 13:28
Copy link

3054 tests run: 2939 passed, 0 failed, 115 skipped (full report)


Flaky tests (1)

Postgres 16

  • test_ondemand_wal_download_in_replication_slot_funcs: release

Code coverage* (full report)

  • functions: 32.7% (6984 of 21338 functions)
  • lines: 50.1% (55003 of 109719 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d0543ee at 2024-07-12T13:30:39.225Z :recycle:

skyzh added a commit that referenced this pull request Jul 15, 2024
As title, there should be a way to detect duplicated harness names in
the future :(

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants