Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_timeline_copy flakiness. #8356

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Fix test_timeline_copy flakiness. #8356

merged 1 commit into from
Jul 15, 2024
+13 −2

Conversation

arssher
Copy link
Contributor

@arssher arssher commented Jul 11, 2024

fixes #8355

@arssher arssher requested a review from koivunej July 11, 2024 13:39
koivunej
koivunej approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oki so it was a case of not waiting as I thought initially. Thanks for the quick fix.

@arssher arssher enabled auto-merge (rebase) July 11, 2024 13:48
@arssher arssher disabled auto-merge July 11, 2024 13:48
@arssher arssher requested a review from a team as a code owner July 11, 2024 13:53
@arssher arssher requested a review from jcsp July 11, 2024 13:53
@arssher arssher enabled auto-merge (rebase) July 11, 2024 13:54
@github-actions GitHub Actions
Copy link

3036 tests run: 2921 passed, 0 failed, 115 skipped (full report)

Flaky tests (1)

Postgres 14

Code coverage* (full report)

  • functions: 32.7% (6967 of 21285 functions)
  • lines: 50.1% (54766 of 109308 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
4404926 at 2024-07-11T14:43:50.338Z :recycle:

@arssher arssher merged commit 4bdfb96 into main Jul 15, 2024
65 checks passed
@arssher arssher deleted the sk-timeline-copy-flaky branch July 15, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcsp jcsp jcsp approved these changes

@koivunej koivunej koivunej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_timeline_copy is flaky
3 participants
@arssher @jcsp @koivunej