Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: turn on safekeeper eviction by default #8352

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Jul 11, 2024

Problem

Ahead of enabling eviction in the field, where it will become the normal/default mode, let's enable it by default throughout our tests in case any issues become visible there.

Summary of changes

  • Make default extra_opts for safekeepers enable offload & deletion
  • Set low timeouts in extra_opts so that tests running for tens of seconds have a chance to hit some of these background operations.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Jul 11, 2024

3226 tests run: 3093 passed, 0 failed, 133 skipped (full report)


Flaky tests (4)

Postgres 15

  • test_isolation[None]: debug
  • test_sharded_timeline_detach_ancestor: debug

Postgres 14

  • test_subscriber_restart: release
  • test_s3_eviction[0.2-True]: debug

Code coverage* (full report)

  • functions: 32.7% (6985 of 21380 functions)
  • lines: 50.1% (55035 of 109932 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
868c02d at 2024-07-17T21:29:29.833Z :recycle:

@jcsp jcsp added the run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label label Jul 11, 2024
@jcsp jcsp changed the title [DNM] tests: turn on safekeeper eviction by default tests: turn on safekeeper eviction by default Jul 16, 2024
@jcsp jcsp marked this pull request as ready for review July 17, 2024 20:56
@jcsp jcsp requested a review from arssher July 17, 2024 20:56
@jcsp jcsp added c/storage/safekeeper Component: storage: safekeeper a/test Area: related to testing labels Jul 17, 2024
@jcsp jcsp merged commit b461755 into main Jul 18, 2024
79 checks passed
@jcsp jcsp deleted the jcsp/sk-eviction-tests branch July 18, 2024 11:59
problame pushed a commit that referenced this pull request Jul 22, 2024
## Problem

Ahead of enabling eviction in the field, where it will become the
normal/default mode, let's enable it by default throughout our tests in
case any issues become visible there.

## Summary of changes

- Make default `extra_opts` for safekeepers enable offload & deletion
- Set low timeouts in `extra_opts` so that tests running for tens of
seconds have a chance to hit some of these background operations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/test Area: related to testing c/storage/safekeeper Component: storage: safekeeper run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants