Remove fs2 dependency #8350
Merged
Remove fs2 dependency #8350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fs2 dependency is not needed anymore after commit d427002.
koivunej
approved these changes
Jul 11, 2024
github-actions
bot
removed
the
approved-for-ci-run
Closed
3036 tests run: 2921 passed, 0 failed, 115 skipped (full report)Flaky tests (2)Postgres 15Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
7ec69bf at 2024-07-11T15:33:13.560Z :recycle: |
arssher
approved these changes
Jul 12, 2024
|
Thanks for the cleanup @japinli! |
skyzh
pushed a commit
that referenced
this pull request
Jul 15, 2024
The fs2 dependency is not needed anymore after commit d427002.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fs2 dependency is not needed anymore after commit d427002.
OTOH, if we need it, how about using fs4 instead of fs2, since fs2 did not update for a long time.