safekeeper: eviction metrics #8348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
added
c/storage/safekeeper
3042 tests run: 2927 passed, 0 failed, 115 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
4f70485 at 2024-07-11T08:20:19.197Z :recycle: |
jcsp
force-pushed
the
jcsp/safekeeper-eviction-metrics
branch
from
94b79d6
to
4f70485
Compare
arssher
approved these changes
Jul 11, 2024
skyzh
pushed a commit
that referenced
this pull request
Jul 15, 2024
## Problem Follow up to #8335, to improve observability of how many evict/restores we are doing. ## Summary of changes - Add `safekeeper_eviction_events_started_total` and `safekeeper_eviction_events_completed_total`, with a "kind" label of evict or restore. This gives us rates, and also ability to calculate how many are in progress. - Generalize SafekeeperMetrics test type to use the same helpers as pageserver, and enable querying any metric. - Read the new metrics at the end of the eviction test.
5 tasks
jcsp
added a commit
that referenced
this pull request
Jul 18, 2024
## Problem This test would occasionally fail its metric check. This could happen in the rare case that the nodes had all been restarted before their most recent eviction. The metric check was added in #8348 ## Summary of changes - Check metrics before each restart, accumulate into a bool that we assert on at the end of the test
problame
pushed a commit
that referenced
this pull request
Jul 22, 2024
## Problem This test would occasionally fail its metric check. This could happen in the rare case that the nodes had all been restarted before their most recent eviction. The metric check was added in #8348 ## Summary of changes - Check metrics before each restart, accumulate into a bool that we assert on at the end of the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Follow up to #8335, to improve observability of how many evict/restores we are doing.
Summary of changes
safekeeper_eviction_events_started_totalandsafekeeper_eviction_events_completed_total, with a "kind" label of evict or restore. This gives us rates, and also ability to calculate how many are in progress.Checklist before requesting a review
Checklist before merging