Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage_controller: fix ReconcilerWaiter::get_status #8341

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

VladLazar
Copy link
Contributor

@VladLazar VladLazar commented Jul 10, 2024

Problem

SeqWait::would_wait_for returns Ok in the case when we would not wait for the sequence number and Err otherwise.
ReconcilerWaiter::get_status uses it the wrong way around. This can cause the storage controller to go into a busy loop
and make it look unavailable to the k8s controller.

Summary of changes

Use SeqWait::would_wait_for correctly.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Problem
SeqWait::would_wait_for returns Ok in the case when we would not
wait for the sequence number and Err otherwise.
ReconcilerWaiter::get_status uses it the wrong way around.

Summary of Changes
Use `SeqWait::would_wait_for` correctly.
Copy link

3042 tests run: 2927 passed, 0 failed, 115 skipped (full report)


Code coverage* (full report)

  • functions: 32.6% (6937 of 21297 functions)
  • lines: 50.0% (54546 of 109186 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
07d43da at 2024-07-10T15:36:57.076Z :recycle:

@VladLazar VladLazar marked this pull request as ready for review July 10, 2024 16:06
@VladLazar VladLazar requested a review from a team as a code owner July 10, 2024 16:06
@VladLazar VladLazar requested review from problame, jcsp and koivunej and removed request for problame July 10, 2024 16:06
@VladLazar VladLazar merged commit d9a8246 into main Jul 11, 2024
66 checks passed
@VladLazar VladLazar deleted the vlad/storcon-fix-reconciler-get-status branch July 11, 2024 14:43
skyzh pushed a commit that referenced this pull request Jul 15, 2024
## Problem
SeqWait::would_wait_for returns Ok in the case when we would not wait
for the sequence number and Err otherwise.
ReconcilerWaiter::get_status uses it the wrong way around. This can
cause the storage controller to go into a busy loop
and make it look unavailable to the k8s controller.

## Summary of changes
Use `SeqWait::would_wait_for` correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants