Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Trigger E2E test only after images available on registry #8336

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rahulinux
Copy link
Contributor

Problem

Trigger E2E tests getting failed on PR because images not available from same commit.

Summary of changes

Adding workflow dependency so that E2E will trigger after building images.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@rahulinux rahulinux requested review from bayandin and a team July 10, 2024 12:59
workflow_run:
workflows: ["Build and Test"]
types:
- completed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, that this will slow down wall CI time quite significant, for the whole test part of build_and_test workflow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, whats the solution here? I don't see how we can depends on only job from another workflow.

Copy link

3042 tests run: 2926 passed, 1 failed, 115 skipped (full report)


Failures on Postgres 14

  • test_pg_regress[4]: debug
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_pg_regress[debug-pg14-4]"
Flaky tests (1)

Postgres 14

Test coverage report is not available

The comment gets automatically updated with the latest test results
3883d23 at 2024-07-10T14:11:00.464Z :recycle:

@bayandin
Copy link
Member

bayandin commented Aug 6, 2024

The issue has been fixed by #8592.
I won't close the PR, but unassigning myself from reviewers

@bayandin bayandin removed their request for review August 6, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants