Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pylint to workflows #8330

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Add pylint to workflows #8330

wants to merge 19 commits into from

Conversation

a-masterov
Copy link
Contributor

Problem

Now we don't run Pylint as a part of a workflow.
However, it can be useful in automatic error detection and style enforcement.
Unfortunately, we cannot turn on all the pylint functions but it's possible to use error detection and enforce some good practices in logging

Summary of changes

Add pylint to workflows, fix some code parts that pylint considers errors, fix logging-fstring-interpolation

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Jul 10, 2024

3042 tests run: 2927 passed, 0 failed, 115 skipped (full report)


Code coverage* (full report)

  • functions: 32.6% (6936 of 21300 functions)
  • lines: 50.0% (54553 of 109200 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
9e0d9f9 at 2024-07-10T11:32:27.526Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant