Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vectored read_blobs function not fill buffer correctly #8324

Closed
wants to merge 4 commits into from

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Jul 9, 2024

There was barely any breakage in #8288 so I'm wondering whether pytests work at all for vectored reads.

This PR is meant to find that out: just break vectored reads completely.

DO NOT MERGE.

@arpad-m arpad-m mentioned this pull request Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

No tests were run or test report is not available

Test coverage report is not available

The comment gets automatically updated with the latest test results
c0ae2c4 at 2024-07-09T16:29:17.172Z :recycle:

@arpad-m
Copy link
Member Author

arpad-m commented Jul 10, 2024

There is a lot of failures. The reason why there isn't a test report is here:

Error: Unhandled error: HttpError: Validation Failed: {"resource":"IssueComment","code":"custom","field":"body","message":"body is too long (maximum is 65536 characters)"}

If you look at the logs manually, you see:

2024-07-10T02:25:27.2012222Z = 372 failed, 123 passed, 12 skipped, 448 errors, 94 rerun in 2144.25s (0:35:44) =

so safe to say, I think there is plenty of vectored read test coverage in the testsuite.

Closing as the experiment has concluded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant