-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: stabilize test_sharding_split_compaction #8318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3042 tests run: 2927 passed, 0 failed, 115 skipped (full report)Flaky tests (4)Postgres 16Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
e8c1c87 at 2024-07-10T09:40:12.887Z :recycle: |
koivunej
reviewed
Jul 9, 2024
895733b
to
5e89a86
Compare
skyzh
approved these changes
Jul 9, 2024
koivunej
reviewed
Jul 10, 2024
skyzh
pushed a commit
that referenced
this pull request
Jul 15, 2024
## Problem This test incorrectly assumed that a post-split compaction would only drop content. This was easily destabilized by any changes to image generation rules. ## Summary of changes - Before split, do a full image layer generation pass, to guarantee that post-split compaction should only drop data, never create it. - Fix the force_image_layer_creation mode of compaction that we use from tests like this: previously it would try and generate image layers even if one already existed with the same layer key, which caused compaction to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a/tech_debt
Area: related to tech debt
a/test
Area: related to testing
c/storage/pageserver
Component: storage: pageserver
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This test incorrectly assumed that a post-split compaction would only drop content. This was easily destabilized by any changes to image generation rules.
In this, and other tests that explicitly create image layers (e.g. latest test_pg_regress & test_isolation), there is also a bug in compaction with force-image-layers, where it will fail trying to create a duplicate image layer.
Summary of changes
Checklist before requesting a review
Checklist before merging