Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: switch to jemalloc #8307

Merged
merged 2 commits into from
Jul 8, 2024
Merged

pageserver: switch to jemalloc #8307

merged 2 commits into from
Jul 8, 2024

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Jul 8, 2024

Problem

  • Resident memory on long running pageserver processes tends to climb: memory fragmentation is suspected.
  • Total resident memory may be a limiting factor for running on smaller nodes.

Summary of changes

  • As a low-energy experiment, switch the pageserver to use jemalloc (not a net-new dependency, proxy already use it)
  • Decide at end of week whether to revert before next release.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

3042 tests run: 2927 passed, 0 failed, 115 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_statvfs_pressure_usage: debug

Code coverage* (full report)

  • functions: 32.6% (6937 of 21279 functions)
  • lines: 50.0% (54538 of 109034 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
8b07cfe at 2024-07-08T12:35:05.159Z :recycle:

@jcsp jcsp marked this pull request as ready for review July 8, 2024 12:51
@jcsp jcsp requested a review from a team as a code owner July 8, 2024 12:51
@jcsp jcsp requested a review from arssher July 8, 2024 12:51
@jcsp jcsp enabled auto-merge (squash) July 8, 2024 12:51
@jcsp jcsp merged commit 1121a1c into main Jul 8, 2024
66 checks passed
@jcsp jcsp deleted the jcsp/pageserver-jemalloc branch July 8, 2024 13:10
skyzh pushed a commit that referenced this pull request Jul 15, 2024
## Problem

- Resident memory on long running pageserver processes tends to climb:
memory fragmentation is suspected.
- Total resident memory may be a limiting factor for running on smaller
nodes.

## Summary of changes

- As a low-energy experiment, switch the pageserver to use jemalloc (not
a net-new dependency, proxy already use it)
- Decide at end of week whether to revert before next release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants