vm-image: Expose new LFC working set size metrics #8298
+29
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In general, rename: - lfc_approximate_working_set_size to - lfc_approximate_working_set_size_seconds For the "main" metrics that are actually scraped and used internally, the old one is just marked as deprecated. For the "autoscaling" metrics, we're not currently using the old one, so we can get away with just replacing it. Also, for the user-visible metrics we'll only store & expose a few different time windows, to avoid making the UI overly busy or bloating our internal metrics storage. But for the autoscaling-related scraper, we aren't storing the metrics, and it's useful to be able to programmatically operate on the trendline of how WSS increases (or doesn't!) window size. So there, we can just output datapoints for each minute. Part of neondatabase/autoscaling#872. See also #7466.
skyzh
approved these changes
Jul 5, 2024
3079 tests run: 2964 passed, 0 failed, 115 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
1127d73 at 2024-07-13T05:33:13.105Z :recycle: |
|
Oh actually I guess this is also blocked on setting '1.4' as the default version of the neon extension 😞 |
This shouldn't actually be merged as part of this PR. It's just to make the images easier to test on staging.
sharnoff
added a commit
to neondatabase/autoscaling
that referenced
this pull request
Jul 7, 2024
Part of #872. This builds on the metrics that will be exposed by neondatabase/neon#8298. For now, we only look at the working set size metrics over various time windows. The algorithm is somewhat straightforward to implement (see wss.go), but unfortunately seems to be difficult to understand *why* it's expected to work. See also: https://www.notion.so/neondatabase/874ef1cc942a4e6592434dbe9e609350
sharnoff
added a commit
to neondatabase/autoscaling
that referenced
this pull request
Jul 7, 2024
Part of #872. This builds on the metrics that will be exposed by neondatabase/neon#8298. For now, we only look at the working set size metrics over various time windows. The algorithm is somewhat straightforward to implement (see wss.go), but unfortunately seems to be difficult to understand *why* it's expected to work. See also: https://www.notion.so/neondatabase/874ef1cc942a4e6592434dbe9e609350
sharnoff
added a commit
to neondatabase/autoscaling
that referenced
this pull request
Jul 10, 2024
Part of #872. This builds on the metrics that will be exposed by neondatabase/neon#8298. For now, we only look at the working set size metrics over various time windows. The algorithm is somewhat straightforward to implement (see wss.go), but unfortunately seems to be difficult to understand *why* it's expected to work. See also: https://www.notion.so/neondatabase/874ef1cc942a4e6592434dbe9e609350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, rename:
lfc_approximate_working_set_sizetolfc_approximate_working_set_size_secondsFor the "main" metrics that are actually scraped and used internally, the old one is just marked as deprecated.
For the "autoscaling" metrics, we're not currently using the old one, so we can get away with just replacing it.
Also, for the user-visible metrics we'll only store & expose a few different time windows, to avoid making the UI overly busy or bloating our internal metrics storage.
But for the autoscaling-related scraper, we aren't storing the metrics, and it's useful to be able to programmatically operate on the trendline of how WSS increases (or doesn't!) with window size. So there, we can just output datapoints for each minute.
Part of neondatabase/autoscaling#872.
See also #7466.
See also https://neondb.slack.com/archives/C06K49H0589/p1720206793137919.
See also https://www.notion.so/neondatabase/874ef1cc942a4e6592434dbe9e609350
This PR is partly pending further testing to validate the intended approach on the autoscaling side, but practically speaking it should be ok to merge as-is - there just might be follow-up changes.
cc @zaynetro re: neondatabase/cloud#14871