Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: postgres_backend: replace abstract shutdown_watcher with CancellationToken #8295

Merged
merged 2 commits into from
Jul 9, 2024
Merged

refactor: postgres_backend: replace abstract shutdown_watcher with CancellationToken #8295

merged 2 commits into from
Jul 9, 2024
+28 −34

Conversation

problame
Copy link
Contributor

@problame problame commented Jul 5, 2024

Preliminary refactoring while working on #7427
and specifically #8286

@problame
refactor: postgres_backend: replace abstract shutdown_watcher with Ca…
b971d1d 
…ncellationToken

Preliminary refactoring while working on #7427
and specifically #8286
@problame problame requested a review from koivunej July 5, 2024 19:39
@problame problame marked this pull request as ready for review July 5, 2024 19:39
@problame problame requested review from a team as code owners July 5, 2024 19:39
@problame problame mentioned this pull request Jul 5, 2024
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024 •
edited
Loading

3092 tests run: 2977 passed, 0 failed, 115 skipped (full report)

Flaky tests (4)

Postgres 15

  • test_ondemand_wal_download_in_replication_slot_funcs: debug
  • test_isolation[None]: debug
  • test_storage_controller_onboarding[True]: debug

Postgres 14

  • test_pg_regress[4]: debug

Code coverage* (full report)

  • functions: 32.6% (6936 of 21280 functions)
  • lines: 50.0% (54542 of 109060 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
cfc2230 at 2024-07-09T17:13:36.470Z :recycle:

koivunej
koivunej approved these changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will regardless be less Arc::clone so safe to do.

@koivunej
Copy link
Contributor

koivunej commented Jul 7, 2024

Need to update workspace hack with cargo hakari generate.

@problame problame enabled auto-merge (squash) July 8, 2024 19:46
@problame problame requested a review from arssher July 9, 2024 17:58
@problame problame merged commit 3f7aebb into main Jul 9, 2024
74 checks passed
@problame problame deleted the problame/postgres_backend_cancellation_token branch July 9, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koivunej koivunej koivunej approved these changes

@conradludgate conradludgate conradludgate approved these changes

@arssher arssher arssher approved these changes

@jcsp jcsp Awaiting requested review from jcsp jcsp is a code owner automatically assigned from neondatabase/safekeepers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@problame @koivunej @conradludgate @arssher