Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): ensure sparse keyspace is ordered #8285

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jul 5, 2024

Problem

fix #8277

Summary of changes

make sure the sparse keyspace has ordered keyspace parts

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/order-sparse-keyspace branch from 23c0e6f to 6b5e118 Compare July 5, 2024 15:52
Copy link

github-actions bot commented Jul 5, 2024

3042 tests run: 2927 passed, 0 failed, 115 skipped (full report)


Code coverage* (full report)

  • functions: 32.6% (6935 of 21276 functions)
  • lines: 50.0% (54509 of 108989 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6b5e118 at 2024-07-05T16:40:15.656Z :recycle:

@jcsp jcsp merged commit 154ba5e into main Jul 8, 2024
65 checks passed
@jcsp jcsp deleted the skyzh/order-sparse-keyspace branch July 8, 2024 13:05
skyzh added a commit that referenced this pull request Jul 15, 2024
## Problem

Sparse keyspaces were constructed with ranges out of order: this didn't break things obviously, but meant that users of KeySpace functions that assume ordering would assert out.

Closes #8277

## Summary of changes

make sure the sparse keyspace has ordered keyspace parts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pageserver: assertion in create_image_layer_for_metadata_keys
2 participants