pageserver: respect has_relmap_file in collect_keyspace #8276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Rarely, a dbdir entry can exist with no
relmap_file_key
data. This causes compaction to fail, because it assumes that if the database exists, then so does the relmap file.Basebackup already handled this using a boolean to record whether such a key exists, but
collect_keyspace
didn't.Closes: #8237
Summary of changes
Checklist before requesting a review
Checklist before merging