Fix openapi specification

[shinyaaa]

Problem

There are some swagger errors in pageserver/src/http/openapi_spec.yml

Error	431	15000	Object includes not allowed fields
Error	569	3100401	should always have a 'required'
Error	569	15000	Object includes not allowed fields
Error	1111	10037	properties members must be schemas

Summary of changes

Fixed above errors.

Checklist before requesting a review

• I have performed a self-review of my code.
• If it is a core feature, I have added thorough tests.
• Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
• If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

• Do not forget to reformat commit message to not include the above checklist

[arpad-m]

Which tool did you run on the swagger file?

[shinyaaa]

I used the "OpenAPI (Swagger) Editor," which is a VS Code extension. Also, we can see the same errors on https://editor.swagger.io/.

Since the file name is openapi_spec.yml, I think that the implementation should follow OpenAPI formatting.
Do you think?

[arpad-m]

Thanks. The file is present in the open source repository but it is written for usage by the closed source control plane. We remove stuff from it that the control plane doesn't use, for example, so it is not a full description of the pageserver's HTTP API.

I have asked my colleauges who work on the control plane to have a look on your PR.

[ololobus]

This fixes some obvious typos, and spec is valid, so I think it's good to go. Thanks!

I was a bit concerned about specifying schema for html response, never used it, but it looks like at least Go client was generated without issues.

I opened an internal client PR https://github.com/neondatabase/cloud/pull/15383

[ololobus]

I think I also messed something up with CI permissions after clicking 'Update with rebase'. Hopefully if you push another commit on your own it will help

[github-actions]

3169 tests run: 3048 passed, 0 failed, 121 skipped (full report)

---

Flaky tests (3)

Postgres 16

• test_change_pageserver: debug
• test_scrubber_physical_gc_ancestors[None]: debug

Postgres 14

• test_delete_timeline_client_hangup: debug

Code coverage* (full report)

• functions: 32.7% (6994 of 21410 functions)
• lines: 50.0% (55220 of 110417 lines)

* collected from Rust tests only

---

_{The comment gets automatically updated with the latest test results
ebb1598 at 2024-07-19T18:28:51.253Z :recycle:}

[ololobus]

Thanks! I manged to generate the client now, so LGTM

[ololobus]

OMG, sorry for accidentally closing it. I just referenced it in the private repo as This is a part of the external contributor fix: https://github.com/neondatabase/neon/pull/8273, and GitHub decided to close this PR because of fix #.... I didn't know that it works for PRs too, only used it for auto-closing issues