-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable core dumps for postgres #8272
Conversation
Set core rmilit to ulimited in compute_ctl, so that all child processes inherit it. We could also set rlimit in relevant startup script, but that way we would depend on external setup and might inadvertently disable it again (core dumping worked in pods, but not in VMs with inittab-based startup).
3024 tests run: 2909 passed, 0 failed, 115 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
a7f56ae at 2024-07-04T21:38:17.465Z :recycle: |
I have tried to reproduce the problem and found that the core limit inside the docker container does not depend on either the limit of the current user in the system (/etc/security/limits.conf) or the limit for the docker daemon.
So, I tried to set the limit in the docker-compose.yml
It works:
Then I tried to run the images with the tag 9799742805 which were built during the workflow for this branch
However, there was no desired effect:
|
Right, hard should be non-zero. In our VMs we have 0 soft and inf as hard limit |
Now the docker-compose.yml:
Restarted with:
So now the hard limit is unlimited, but the soft limit still equals 0 |
hmhm, i assume that you are using https://github.com/neondatabase/neon/blob/1afab13ccb95ed083397c5bff1e31ae1631b1091/docker-compose/docker-compose.yml hence compute is started by that script:
so compute image, which is Overall for this patch you can just do https://github.com/neondatabase/neon?tab=readme-ov-file#running-neon-database (but docker compose is also fine, but a bit more heavy) |
Oh, it's my fault, I forgot the
|
Nice, thank you! Can you approve PR then? It will be deployed to staging automatically, and we can get backtraces of LR issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code works corrrectly
Set core rmilit to ulimited in compute_ctl, so that all child processes inherit it. We could also set rlimit in relevant startup script, but that way we would depend on external setup and might inadvertently disable it again (core dumping worked in pods, but not in VMs with inittab-based startup).
Set core rmilit to ulimited in compute_ctl, so that all child processes inherit it. We could also set rlimit in relevant startup script, but that way we would depend on external setup and might inadvertently disable it again (core dumping worked in pods, but not in VMs with inittab-based startup).