Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: make location_conf_churn more robust #8271

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Jul 4, 2024

Problem

This test directly manages locations on pageservers and configuration of an endpoint. However, it did not switch off the parts of the storage controller that attempt to do the same: occasionally, the test would fail in a strange way such as a compute failing to accept a reconfiguration request.

Summary of changes

  • Wire up the storage controller's compute notification hook to a no-op handler
  • Configure the tenant's scheduling policy to Stop.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added a/test Area: related to testing c/storage/controller Component: Storage Controller labels Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

3018 tests run: 2903 passed, 0 failed, 115 skipped (full report)


Flaky tests (3)

Postgres 15

Postgres 14

  • test_statvfs_pressure_usage: debug
  • test_replica_query_race: release

Code coverage* (full report)

  • functions: 32.6% (6929 of 21268 functions)
  • lines: 50.0% (54450 of 108884 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
4b18fc6 at 2024-07-04T19:50:32.750Z :recycle:

@jcsp jcsp marked this pull request as ready for review July 5, 2024 09:08
@jcsp jcsp requested a review from VladLazar July 5, 2024 09:09
@jcsp jcsp merged commit 5aae806 into main Jul 5, 2024
69 checks passed
@jcsp jcsp deleted the jcsp/storcon-location-churn branch July 5, 2024 09:34
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
## Problem

This test directly manages locations on pageservers and configuration of
an endpoint. However, it did not switch off the parts of the storage
controller that attempt to do the same: occasionally, the test would
fail in a strange way such as a compute failing to accept a
reconfiguration request.

## Summary of changes

- Wire up the storage controller's compute notification hook to a no-op
handler
- Configure the tenant's scheduling policy to Stop.
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
## Problem

This test directly manages locations on pageservers and configuration of
an endpoint. However, it did not switch off the parts of the storage
controller that attempt to do the same: occasionally, the test would
fail in a strange way such as a compute failing to accept a
reconfiguration request.

## Summary of changes

- Wire up the storage controller's compute notification hook to a no-op
handler
- Configure the tenant's scheduling policy to Stop.
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
## Problem

This test directly manages locations on pageservers and configuration of
an endpoint. However, it did not switch off the parts of the storage
controller that attempt to do the same: occasionally, the test would
fail in a strange way such as a compute failing to accept a
reconfiguration request.

## Summary of changes

- Wire up the storage controller's compute notification hook to a no-op
handler
- Configure the tenant's scheduling policy to Stop.
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
## Problem

This test directly manages locations on pageservers and configuration of
an endpoint. However, it did not switch off the parts of the storage
controller that attempt to do the same: occasionally, the test would
fail in a strange way such as a compute failing to accept a
reconfiguration request.

## Summary of changes

- Wire up the storage controller's compute notification hook to a no-op
handler
- Configure the tenant's scheduling policy to Stop.
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
## Problem

This test directly manages locations on pageservers and configuration of
an endpoint. However, it did not switch off the parts of the storage
controller that attempt to do the same: occasionally, the test would
fail in a strange way such as a compute failing to accept a
reconfiguration request.

## Summary of changes

- Wire up the storage controller's compute notification hook to a no-op
handler
- Configure the tenant's scheduling policy to Stop.
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
## Problem

This test directly manages locations on pageservers and configuration of
an endpoint. However, it did not switch off the parts of the storage
controller that attempt to do the same: occasionally, the test would
fail in a strange way such as a compute failing to accept a
reconfiguration request.

## Summary of changes

- Wire up the storage controller's compute notification hook to a no-op
handler
- Configure the tenant's scheduling policy to Stop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/test Area: related to testing c/storage/controller Component: Storage Controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants