Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: extend allow list in deletion test #8268

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Jul 4, 2024

Problem

1ea5d8b tolerated this as an error message, but it can show up in logs as well.

Example failure: https://neon-github-public-dev.s3.amazonaws.com/reports/pr-8201/9780147712/index.html#testresult/263422f5f5f292ea/retries

Summary of changes

  • Tolerate "failed to delete 1 objects" in pageserver logs, this occurs occasionally when injected failures exhaust deletion's retries.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added the a/test Area: related to testing label Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

3006 tests run: 2891 passed, 0 failed, 115 skipped (full report)


Code coverage* (full report)

  • functions: 32.7% (6933 of 21219 functions)
  • lines: 50.1% (54440 of 108708 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
eed4938 at 2024-07-04T15:53:10.342Z :recycle:

@jcsp jcsp marked this pull request as ready for review July 4, 2024 19:01
@jcsp jcsp requested a review from yliang412 July 4, 2024 19:01
@jcsp jcsp merged commit e25ac31 into main Jul 5, 2024
69 checks passed
@jcsp jcsp deleted the jcsp/delete-allow-list branch July 5, 2024 09:09
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
## Problem

1ea5d8b tolerated this as an error
message, but it can show up in logs as well.

Example failure:
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-8201/9780147712/index.html#testresult/263422f5f5f292ea/retries

## Summary of changes

- Tolerate "failed to delete 1 objects" in pageserver logs, this occurs
occasionally when injected failures exhaust deletion's retries.
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
## Problem

1ea5d8b tolerated this as an error
message, but it can show up in logs as well.

Example failure:
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-8201/9780147712/index.html#testresult/263422f5f5f292ea/retries

## Summary of changes

- Tolerate "failed to delete 1 objects" in pageserver logs, this occurs
occasionally when injected failures exhaust deletion's retries.
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
## Problem

1ea5d8b tolerated this as an error
message, but it can show up in logs as well.

Example failure:
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-8201/9780147712/index.html#testresult/263422f5f5f292ea/retries

## Summary of changes

- Tolerate "failed to delete 1 objects" in pageserver logs, this occurs
occasionally when injected failures exhaust deletion's retries.
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
## Problem

1ea5d8b tolerated this as an error
message, but it can show up in logs as well.

Example failure:
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-8201/9780147712/index.html#testresult/263422f5f5f292ea/retries

## Summary of changes

- Tolerate "failed to delete 1 objects" in pageserver logs, this occurs
occasionally when injected failures exhaust deletion's retries.
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
## Problem

1ea5d8b tolerated this as an error
message, but it can show up in logs as well.

Example failure:
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-8201/9780147712/index.html#testresult/263422f5f5f292ea/retries

## Summary of changes

- Tolerate "failed to delete 1 objects" in pageserver logs, this occurs
occasionally when injected failures exhaust deletion's retries.
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
## Problem

1ea5d8b tolerated this as an error
message, but it can show up in logs as well.

Example failure:
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-8201/9780147712/index.html#testresult/263422f5f5f292ea/retries

## Summary of changes

- Tolerate "failed to delete 1 objects" in pageserver logs, this occurs
occasionally when injected failures exhaust deletion's retries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/test Area: related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants