Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten compression algorithm setting #8265

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Flatten compression algorithm setting #8265

merged 3 commits into from
Jul 4, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Jul 4, 2024

This flattens the compression algorithm setting, removing the Option<_> wrapping layer. It also adds a specific setting for disabled compression with the continued ability to read copmressed data, giving us the option to more easily back out of a compression rollout, should the need arise.

Implements my suggestion from #8238 (comment) , inspired by Christian's review in #8238 (review) .

Part of #5431

@arpad-m arpad-m requested a review from a team as a code owner July 4, 2024 13:19
@arpad-m arpad-m requested a review from jcsp July 4, 2024 13:19
Copy link

github-actions bot commented Jul 4, 2024

3018 tests run: 2903 passed, 0 failed, 115 skipped (full report)


Code coverage* (full report)

  • functions: 32.6% (6933 of 21268 functions)
  • lines: 50.0% (54463 of 108884 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
5884fe8 at 2024-07-04T17:07:22.807Z :recycle:

@arpad-m arpad-m enabled auto-merge (squash) July 4, 2024 16:16
@arpad-m arpad-m merged commit adde0ec into main Jul 4, 2024
57 of 58 checks passed
@arpad-m arpad-m deleted the arpad/compression_4 branch July 4, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants