Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(build-and-test): add conclusion job #8246

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Jul 3, 2024

Problem

Currently, if you need to rename a job and the job is listed in branch protection rules, the PR won't be allowed to merge.

Summary of changes

  • Add conclusion job that fails if any of its dependencies don't finish successfully

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Jul 3, 2024

3031 tests run: 2916 passed, 0 failed, 115 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_pg_regress[None]: debug

Code coverage* (full report)

  • functions: 32.7% (6933 of 21207 functions)
  • lines: 50.1% (54426 of 108678 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b82f844 at 2024-07-04T07:47:52.923Z :recycle:

@bayandin bayandin marked this pull request as ready for review July 3, 2024 19:14
@bayandin bayandin requested a review from a team July 3, 2024 20:13
.github/workflows/build_and_test.yml Show resolved Hide resolved
@bayandin bayandin merged commit 5b69b32 into main Jul 4, 2024
70 checks passed
@bayandin bayandin deleted the bayandin/add-conclusion branch July 4, 2024 08:20
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
## Problem

Currently, if you need to rename a job and the job is listed in [branch
protection
rules](https://github.com/neondatabase/neon/settings/branch_protection_rules),
the PR won't be allowed to merge.

## Summary of changes
- Add `conclusion` job that fails if any of its dependencies don't
finish successfully
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
## Problem

Currently, if you need to rename a job and the job is listed in [branch
protection
rules](https://github.com/neondatabase/neon/settings/branch_protection_rules),
the PR won't be allowed to merge.

## Summary of changes
- Add `conclusion` job that fails if any of its dependencies don't
finish successfully
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
## Problem

Currently, if you need to rename a job and the job is listed in [branch
protection
rules](https://github.com/neondatabase/neon/settings/branch_protection_rules),
the PR won't be allowed to merge.

## Summary of changes
- Add `conclusion` job that fails if any of its dependencies don't
finish successfully
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
## Problem

Currently, if you need to rename a job and the job is listed in [branch
protection
rules](https://github.com/neondatabase/neon/settings/branch_protection_rules),
the PR won't be allowed to merge.

## Summary of changes
- Add `conclusion` job that fails if any of its dependencies don't
finish successfully
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
## Problem

Currently, if you need to rename a job and the job is listed in [branch
protection
rules](https://github.com/neondatabase/neon/settings/branch_protection_rules),
the PR won't be allowed to merge.

## Summary of changes
- Add `conclusion` job that fails if any of its dependencies don't
finish successfully
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
## Problem

Currently, if you need to rename a job and the job is listed in [branch
protection
rules](https://github.com/neondatabase/neon/settings/branch_protection_rules),
the PR won't be allowed to merge.

## Summary of changes
- Add `conclusion` job that fails if any of its dependencies don't
finish successfully
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants