-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pageserver): rewrite streaming vectored read planner #8242
Conversation
Signed-off-by: Alex Chi Z <chi@neon.tech>
3061 tests run: 2946 passed, 0 failed, 115 skipped (full report)Flaky tests (3)Postgres 16
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
55da0a3 at 2024-07-11T18:36:15.824Z :recycle: |
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'd like to get rid of that VectoredReadBuilder
constructor if possible.
Signed-off-by: Alex Chi Z <chi@neon.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pg_regress failure is strange, but I don't see anything in this pr could have caused it.
Might be good to note down the link to the failure somewhere
Rewrite streaming vectored read planner to be a separate struct. The API is designed to produce batches around `max_read_size` instead of exactly less than that so that `handle_XX` returns one batch a time. --------- Signed-off-by: Alex Chi Z <chi@neon.tech>
Problem
Rewrite streaming vectored read planner to be a separate struct. The API is designed to produce batches around
max_read_size
instead of exactly less than that so thathandle_XX
returns one batch a time.Summary of changes
Checklist before requesting a review
Checklist before merging