Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI(benchmarking): move psql queries to actions/run-python-test-set #8230

Merged
merged 1 commit into from
Jul 2, 2024
Merged

CI(benchmarking): move psql queries to actions/run-python-test-set #8230

merged 1 commit into from
Jul 2, 2024

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Jul 2, 2024 •
edited
Loading

Problem

Some of the Nightly benchmarks fail with the error

+ /tmp/neon/pg_install/v14/bin/pgbench --version
/tmp/neon/pg_install/v14/bin/pgbench: error while loading shared libraries: libpq.so.5: cannot open shared object file: No such file or directory

Originally, we added the pgbench --version call to check that pgbench is installed and to fail earlier if it's not.
The failure happens because we don't have LD_LIBRARY_PATH set for every job, and it also affects psql command.
We can move it to actions/run-python-test-set so as not to duplicate code (as it already have LD_LIBRARY_PATH set).

Summary of changes

  • Remove pgbench --version call
  • Move psql commands to common actions/run-python-test-set

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

3000 tests run: 2885 passed, 0 failed, 115 skipped (full report)

Flaky tests (1)

Postgres 14

Code coverage* (full report)

  • functions: 32.7% (6936 of 21213 functions)
  • lines: 50.0% (54331 of 108576 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
26bf0ce at 2024-07-02T15:34:03.113Z :recycle:

@bayandin bayandin marked this pull request as ready for review July 2, 2024 13:17
@bayandin bayandin requested a review from Bodobolero July 2, 2024 13:24
Bodobolero
Bodobolero approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@Bodobolero Bodobolero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but have one suggestion

.github/actions/run-python-test-set/action.yml Show resolved Hide resolved
@bayandin bayandin force-pushed the bayandin/fix-benchmarking-workflow branch 2 times, most recently from aa75464 to 26bf0ce Compare July 2, 2024 14:41
@bayandin bayandin enabled auto-merge (squash) July 2, 2024 14:49
@bayandin bayandin merged commit 6216df7 into main Jul 2, 2024
126 of 140 checks passed
@bayandin bayandin deleted the bayandin/fix-benchmarking-workflow branch July 2, 2024 15:21
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
@bayandin @VladLazar
CI(benchmarking): move psql queries to actions/run-python-test-set (#…
d80b533 
…8230)

## Problem

Some of the Nightly benchmarks fail with the error
```
+ /tmp/neon/pg_install/v14/bin/pgbench --version
/tmp/neon/pg_install/v14/bin/pgbench: error while loading shared libraries: libpq.so.5: cannot open shared object file: No such file or directory
```
Originally, we added the `pgbench --version` call to check that
`pgbench` is installed and to fail earlier if it's not.
The failure happens because we don't have `LD_LIBRARY_PATH` set for
every job, and it also affects `psql` command.
We can move it to `actions/run-python-test-set` so as not to duplicate
code (as it already have `LD_LIBRARY_PATH` set).

## Summary of changes
- Remove `pgbench --version` call
- Move `psql` commands to common `actions/run-python-test-set`
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
@bayandin @VladLazar
CI(benchmarking): move psql queries to actions/run-python-test-set (#…
0b62c26 
…8230)

## Problem

Some of the Nightly benchmarks fail with the error
```
+ /tmp/neon/pg_install/v14/bin/pgbench --version
/tmp/neon/pg_install/v14/bin/pgbench: error while loading shared libraries: libpq.so.5: cannot open shared object file: No such file or directory
```
Originally, we added the `pgbench --version` call to check that
`pgbench` is installed and to fail earlier if it's not.
The failure happens because we don't have `LD_LIBRARY_PATH` set for
every job, and it also affects `psql` command.
We can move it to `actions/run-python-test-set` so as not to duplicate
code (as it already have `LD_LIBRARY_PATH` set).

## Summary of changes
- Remove `pgbench --version` call
- Move `psql` commands to common `actions/run-python-test-set`
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
@bayandin @VladLazar
CI(benchmarking): move psql queries to actions/run-python-test-set (#…
1ba0a65 
…8230)

## Problem

Some of the Nightly benchmarks fail with the error
```
+ /tmp/neon/pg_install/v14/bin/pgbench --version
/tmp/neon/pg_install/v14/bin/pgbench: error while loading shared libraries: libpq.so.5: cannot open shared object file: No such file or directory
```
Originally, we added the `pgbench --version` call to check that
`pgbench` is installed and to fail earlier if it's not.
The failure happens because we don't have `LD_LIBRARY_PATH` set for
every job, and it also affects `psql` command.
We can move it to `actions/run-python-test-set` so as not to duplicate
code (as it already have `LD_LIBRARY_PATH` set).

## Summary of changes
- Remove `pgbench --version` call
- Move `psql` commands to common `actions/run-python-test-set`
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
@bayandin @VladLazar
CI(benchmarking): move psql queries to actions/run-python-test-set (#…
22446e7 
…8230)

## Problem

Some of the Nightly benchmarks fail with the error
```
+ /tmp/neon/pg_install/v14/bin/pgbench --version
/tmp/neon/pg_install/v14/bin/pgbench: error while loading shared libraries: libpq.so.5: cannot open shared object file: No such file or directory
```
Originally, we added the `pgbench --version` call to check that
`pgbench` is installed and to fail earlier if it's not.
The failure happens because we don't have `LD_LIBRARY_PATH` set for
every job, and it also affects `psql` command.
We can move it to `actions/run-python-test-set` so as not to duplicate
code (as it already have `LD_LIBRARY_PATH` set).

## Summary of changes
- Remove `pgbench --version` call
- Move `psql` commands to common `actions/run-python-test-set`
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
@bayandin @VladLazar
CI(benchmarking): move psql queries to actions/run-python-test-set (#…
4884443 
…8230)

## Problem

Some of the Nightly benchmarks fail with the error
```
+ /tmp/neon/pg_install/v14/bin/pgbench --version
/tmp/neon/pg_install/v14/bin/pgbench: error while loading shared libraries: libpq.so.5: cannot open shared object file: No such file or directory
```
Originally, we added the `pgbench --version` call to check that
`pgbench` is installed and to fail earlier if it's not.
The failure happens because we don't have `LD_LIBRARY_PATH` set for
every job, and it also affects `psql` command.
We can move it to `actions/run-python-test-set` so as not to duplicate
code (as it already have `LD_LIBRARY_PATH` set).

## Summary of changes
- Remove `pgbench --version` call
- Move `psql` commands to common `actions/run-python-test-set`
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
@bayandin @VladLazar
CI(benchmarking): move psql queries to actions/run-python-test-set (#…
64ccdf6 
…8230)

## Problem

Some of the Nightly benchmarks fail with the error
```
+ /tmp/neon/pg_install/v14/bin/pgbench --version
/tmp/neon/pg_install/v14/bin/pgbench: error while loading shared libraries: libpq.so.5: cannot open shared object file: No such file or directory
```
Originally, we added the `pgbench --version` call to check that
`pgbench` is installed and to fail earlier if it's not.
The failure happens because we don't have `LD_LIBRARY_PATH` set for
every job, and it also affects `psql` command.
We can move it to `actions/run-python-test-set` so as not to duplicate
code (as it already have `LD_LIBRARY_PATH` set).

## Summary of changes
- Remove `pgbench --version` call
- Move `psql` commands to common `actions/run-python-test-set`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bodobolero Bodobolero Bodobolero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bayandin @Bodobolero