-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rfcs: add RFC for timeline archival #8221
Conversation
3117 tests run: 3002 passed, 0 failed, 115 skipped (full report)Flaky tests (2)Postgres 16
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
f7338e2 at 2024-07-09T18:16:41.194Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with the overal approach
Got some clarification requests, suggestions, and a concern about integrity of tenant manifest updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice
Added a sentence to make that clearer -- it's a concept I want to add soon and use a few different places (see also: https://neondb.slack.com/archives/C06Q6MQ2QSC/p1719825156554879) |
bc0ad6a
to
f214285
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a well written RFC, it is thought through and I think a good plan forward. Thinking of it, the feature is bigger than I thought, it touches so many components of the pageserver, but I think there is a clear path to getting it implemented piece by piece.
I'd like to see a description of the deletion flow for a timeline, now that it is mentioned in the manifest. Should we first delete the timeline folder and then remove it from the manifest, or should it be the other way around?
And how does that interact with timelines that are either in the process of being offloaded or in the process of being archived, i.e. if we first delete in the manifest and then crash, will it look after a restart like a non-offloaded but archived timeline?
A design for a cheap low-resource state for idle timelines: - #8088
A design for a cheap low-resource state for idle timelines:
Checklist before requesting a review
Checklist before merging