Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: report blame for passthrough disconnect io errors #8170

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

conradludgate
Copy link
Contributor

Problem

Hard to debug the disconnection reason currently.

Summary of changes

Keep track of error-direction, and therefore error source (client vs compute) during passthrough.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@conradludgate conradludgate requested a review from a team as a code owner June 26, 2024 13:29
Copy link

github-actions bot commented Jun 26, 2024

2910 tests run: 2793 passed, 0 failed, 117 skipped (full report)


Code coverage* (full report)

  • functions: 32.8% (6894 of 21018 functions)
  • lines: 50.3% (53909 of 107202 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d0feece at 2024-06-26T15:25:17.551Z :recycle:

@conradludgate conradludgate enabled auto-merge (squash) June 26, 2024 14:30
Copy link
Contributor

@khanova khanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

@conradludgate conradludgate merged commit d7e349d into main Jun 26, 2024
56 of 57 checks passed
@conradludgate conradludgate deleted the proxy-report-io-error-source branch June 26, 2024 15:11
conradludgate added a commit that referenced this pull request Jun 27, 2024
## Problem

Hard to debug the disconnection reason currently.

## Summary of changes

Keep track of error-direction, and therefore error source (client vs
compute) during passthrough.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants