Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L0 flush: avoid short-lived allocation when checking key_range empty #8154

Merged
merged 1 commit into from
Jun 25, 2024
Merged

L0 flush: avoid short-lived allocation when checking key_range empty #8154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions pageserver/src/tenant/storage_layer/inmemory_layer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,18 +622,16 @@ impl InMemoryLayer {

let end_lsn = *self.end_lsn.get().unwrap();

let keys: Vec<_> = if let Some(key_range) = key_range {
let key_count = if let Some(key_range) = key_range {
inner
.index
.iter()
.filter(|(k, _)| key_range.contains(k))
.map(|(k, m)| (k.to_i128(), m))
.collect()
.count()
} else {
inner.index.iter().map(|(k, m)| (k.to_i128(), m)).collect()
inner.index.len()
};

if keys.is_empty() {
if key_count == 0 {
return Ok(None);
}

Expand Down
Loading