Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly warnings 2024 june #8151

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Conversation

conradludgate
Copy link
Contributor

@conradludgate conradludgate commented Jun 25, 2024

Problem

new clippy warnings on nightly.

Summary of changes

broken up each commit by warning type.

  1. Remove some unnecessary refs.
  2. In edition 2024, inference will default to ! and not ().
  3. Clippy complains about doc comment indentation
  4. Fix Trait + ?Sized where Trait: Sized.
  5. diesel_derives triggering non_local_defintions

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Jun 25, 2024

3036 tests run: 2921 passed, 0 failed, 115 skipped (full report)


Flaky tests (2)

Postgres 16

  • test_statvfs_pressure_usage: release
  • test_subscriber_restart: release

Code coverage* (full report)

  • functions: 32.7% (6968 of 21285 functions)
  • lines: 50.1% (54785 of 109302 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
80b7b9b at 2024-07-11T14:39:36.033Z :recycle:

Base automatically changed from fix-nightly-2024-june to main July 9, 2024 17:25
@conradludgate conradludgate force-pushed the fix-nightly-warnings-2024-june branch from 9510b41 to f231bcf Compare July 11, 2024 13:38
@conradludgate conradludgate force-pushed the fix-nightly-warnings-2024-june branch from f231bcf to 80b7b9b Compare July 11, 2024 13:52
@conradludgate conradludgate marked this pull request as ready for review July 11, 2024 13:53
@conradludgate conradludgate requested review from a team as code owners July 11, 2024 13:53
@conradludgate conradludgate enabled auto-merge (squash) July 12, 2024 12:38
@conradludgate conradludgate merged commit 411a130 into main Jul 12, 2024
66 checks passed
@conradludgate conradludgate deleted the fix-nightly-warnings-2024-june branch July 12, 2024 12:58
skyzh pushed a commit that referenced this pull request Jul 15, 2024
## Problem

new clippy warnings on nightly.

## Summary of changes

broken up each commit by warning type.
1. Remove some unnecessary refs.
2. In edition 2024, inference will default to `!` and not `()`.
3. Clippy complains about doc comment indentation
4. Fix `Trait + ?Sized` where `Trait: Sized`.
5. diesel_derives triggering `non_local_defintions`
arpad-m added a commit that referenced this pull request Jul 16, 2024
The `doc_lazy_continuation` lint of clippy is still unknown on latest
rust stable.

Fixes fall-out from #8151.
problame pushed a commit that referenced this pull request Jul 22, 2024
The `doc_lazy_continuation` lint of clippy is still unknown on latest
rust stable.

Fixes fall-out from #8151.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants