-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nightly warnings 2024 june #8151
Merged
Merged
+64
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3036 tests run: 2921 passed, 0 failed, 115 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
80b7b9b at 2024-07-11T14:39:36.033Z :recycle: |
dd70b49
to
36a768e
Compare
9510b41
to
f231bcf
Compare
f231bcf
to
80b7b9b
Compare
skyzh
approved these changes
Jul 11, 2024
arssher
approved these changes
Jul 11, 2024
koivunej
approved these changes
Jul 11, 2024
arpad-m
approved these changes
Jul 11, 2024
khanova
approved these changes
Jul 12, 2024
skyzh
pushed a commit
that referenced
this pull request
Jul 15, 2024
## Problem new clippy warnings on nightly. ## Summary of changes broken up each commit by warning type. 1. Remove some unnecessary refs. 2. In edition 2024, inference will default to `!` and not `()`. 3. Clippy complains about doc comment indentation 4. Fix `Trait + ?Sized` where `Trait: Sized`. 5. diesel_derives triggering `non_local_defintions`
arpad-m
added a commit
that referenced
this pull request
Jul 16, 2024
The `doc_lazy_continuation` lint of clippy is still unknown on latest rust stable. Fixes fall-out from #8151.
problame
pushed a commit
that referenced
this pull request
Jul 22, 2024
The `doc_lazy_continuation` lint of clippy is still unknown on latest rust stable. Fixes fall-out from #8151.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
new clippy warnings on nightly.
Summary of changes
broken up each commit by warning type.
!
and not()
.Trait + ?Sized
whereTrait: Sized
.non_local_defintions
Checklist before requesting a review
Checklist before merging