Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy fix wake compute console retry #8141

Merged
merged 9 commits into from
Jun 25, 2024

Conversation

conradludgate
Copy link
Contributor

@conradludgate conradludgate commented Jun 24, 2024

Problem

  1. Proxy is retrying errors from cplane that shouldn't be retried
  2. Proxy is not using the retry_after_ms value

Summary of changes

  1. Correct the could_retry impl for ConsoleError.
  2. Update could_retry interface to support returning a fixed wait duration.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Jun 24, 2024

2910 tests run: 2793 passed, 0 failed, 117 skipped (full report)


Flaky tests (1)

Postgres 14

Code coverage* (full report)

  • functions: 32.7% (6870 of 20995 functions)
  • lines: 50.2% (53649 of 106917 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b224bd0 at 2024-06-25T17:55:34.753Z :recycle:

@conradludgate conradludgate force-pushed the proxy-fix-wake-compute-console-retry branch 3 times, most recently from b36b3c5 to 6db02f0 Compare June 25, 2024 07:39
@conradludgate conradludgate marked this pull request as ready for review June 25, 2024 07:55
@conradludgate conradludgate requested a review from a team as a code owner June 25, 2024 07:55
@conradludgate conradludgate enabled auto-merge (squash) June 25, 2024 08:10
@conradludgate conradludgate force-pushed the proxy-fix-wake-compute-console-retry branch from 23f004a to a5be4fb Compare June 25, 2024 09:27
@conradludgate conradludgate force-pushed the proxy-fix-wake-compute-console-retry branch from 77615b2 to a0e9403 Compare June 25, 2024 14:40
@conradludgate conradludgate merged commit 6c5d3b5 into main Jun 25, 2024
57 checks passed
@conradludgate conradludgate deleted the proxy-fix-wake-compute-console-retry branch June 25, 2024 18:07
conradludgate added a commit that referenced this pull request Jun 27, 2024
## Problem

1. Proxy is retrying errors from cplane that shouldn't be retried
2. ~~Proxy is not using the retry_after_ms value~~

## Summary of changes

1. Correct the could_retry impl for ConsoleError.
2. ~~Update could_retry interface to support returning a fixed wait
duration.~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants