pageserver: remove attach/detach apis #8134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
added
c/storage/pageserver
5 tasks
2910 tests run: 2793 passed, 0 failed, 117 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
810bed0 at 2024-06-25T14:47:33.511Z :recycle: |
jcsp
force-pushed
the
jcsp/remove-attach-detach-apis
branch
from
0ecb9a3
to
8334f70
Compare
jcsp
force-pushed
the
jcsp/remove-attach-detach-apis
branch
from
8334f70
to
810bed0
Compare
problame
approved these changes
Jun 25, 2024
conradludgate
pushed a commit
that referenced
this pull request
Jun 27, 2024
## Problem These APIs have been deprecated for some time, but were still used from test code. Closes: #4282 ## Summary of changes - It is still convenient to do a "tenant_attach" from a test without having to write out a location_conf body, so those test methods have been retained with implementations that call through to their location_conf equivalent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
These APIs have been deprecated for some time, but were still used from test code.
Closes: #4282
Summary of changes
Checklist before requesting a review
Checklist before merging