Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate waltmp file on creation #8133

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Truncate waltmp file on creation #8133

merged 2 commits into from
Jun 24, 2024

Conversation

petuhovskiy
Copy link
Member

Previously in safekeeper code, new segment file was opened without truncate option. I don't think there is a reason to do it, this commit replaces it with File::create to make it simpler and remove clippy::suspicious_open_options linter warning.

@petuhovskiy petuhovskiy requested a review from a team as a code owner June 23, 2024 12:33
@petuhovskiy petuhovskiy requested a review from arssher June 23, 2024 12:33
Copy link

github-actions bot commented Jun 23, 2024

2916 tests run: 2799 passed, 0 failed, 117 skipped (full report)


Code coverage* (full report)

  • functions: 32.5% (6866 of 21131 functions)
  • lines: 50.0% (53370 of 106768 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
361d6f8 at 2024-06-24T13:34:07.633Z :recycle:

@petuhovskiy petuhovskiy enabled auto-merge (squash) June 24, 2024 12:46
@petuhovskiy petuhovskiy merged commit a4db2af into main Jun 24, 2024
61 checks passed
@petuhovskiy petuhovskiy deleted the fix-sk-waltmp branch June 24, 2024 14:08
conradludgate pushed a commit that referenced this pull request Jun 27, 2024
Previously in safekeeper code, new segment file was opened without
truncate option. I don't think there is a reason to do it, this commit
replaces it with `File::create` to make it simpler and remove
`clippy::suspicious_open_options` linter warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants