Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storcon_cli: remove old tenant-scatter command #8127

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Jun 21, 2024

Problem

This command was used in the very early days of sharding, before the storage controller had anti-affinity + scheduling optimization to spread out shards.

Summary of changes

  • Remove storcon_cli tenant-scatter

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added a/tech_debt Area: related to tech debt c/storage/controller Component: Storage Controller labels Jun 21, 2024
@jcsp jcsp marked this pull request as ready for review June 21, 2024 10:42
@jcsp jcsp requested a review from skyzh June 21, 2024 10:42
Copy link

3228 tests run: 3111 passed, 0 failed, 117 skipped (full report)


Code coverage* (full report)

  • functions: 32.3% (6840 of 21155 functions)
  • lines: 49.8% (53334 of 107056 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
5120eb4 at 2024-06-21T10:44:30.264Z :recycle:

@jcsp jcsp enabled auto-merge (squash) June 21, 2024 14:39
@jcsp jcsp merged commit 3d76093 into main Jun 24, 2024
68 checks passed
@jcsp jcsp deleted the jcsp/storcon-cli-cruft branch June 24, 2024 16:57
conradludgate pushed a commit that referenced this pull request Jun 27, 2024
## Problem

This command was used in the very early days of sharding, before the
storage controller had anti-affinity + scheduling optimization to spread
out shards.

## Summary of changes

- Remove `storcon_cli tenant-scatter`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/controller Component: Storage Controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants