Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eviction_state to control file #8125

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Add eviction_state to control file #8125

merged 1 commit into from
Jun 21, 2024

Conversation

petuhovskiy
Copy link
Member

This is a preparation for #8022, to make the PR both backwards and foward compatible.

This commit adds eviction_state field to control file. Adds support for reading it, but writes control file in old format where possible, to keep the disk format forward compatible.

Note: in patch_control_file, new field gets serialized to json like this:

  • "eviction_state": "Present"
  • "eviction_state": {"Offloaded": "0/8F"}

@petuhovskiy petuhovskiy requested a review from a team as a code owner June 20, 2024 21:56
@petuhovskiy petuhovskiy requested review from jcsp and arssher June 20, 2024 21:56
Copy link

3228 tests run: 3111 passed, 0 failed, 117 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_compute_pageserver_connection_stress: release

Code coverage* (full report)

  • functions: 32.3% (6850 of 21180 functions)
  • lines: 49.8% (53374 of 107163 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
735481e at 2024-06-20T23:30:25.988Z :recycle:

@petuhovskiy petuhovskiy merged commit f45cf28 into main Jun 21, 2024
68 of 69 checks passed
@petuhovskiy petuhovskiy deleted the sk-eviction-state branch June 21, 2024 12:15
conradludgate pushed a commit that referenced this pull request Jun 27, 2024
This is a preparation for #8022, to make the PR both backwards and
foward compatible.

This commit adds `eviction_state` field to control file. Adds support
for reading it, but writes control file in old format where possible, to
keep the disk format forward compatible.

Note: in `patch_control_file`, new field gets serialized to json like
this:
- `"eviction_state": "Present"`
- `"eviction_state": {"Offloaded": "0/8F"}`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants