Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pageserver): add an optional lease to the get_lsn_by_timestamp API #8104

Merged
merged 9 commits into from
Jun 24, 2024
Merged

feat(pageserver): add an optional lease to the get_lsn_by_timestamp API #8104

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1c37ca8
feat(pageserver): add an optional lease to the get_lsn_by_timestamp API
yliang412 Jun 18, 2024
67c2e7c
update openapi spec to use the same field name
yliang412 Jun 18, 2024
8ce833b
Merge branch 'main' into yuchen/get-lsn-by-ts-leases
yliang412 Jun 18, 2024
491c4f6
Merge branch 'main' into yuchen/get-lsn-by-ts-leases
yliang412 Jun 19, 2024
ca7dcfe
log error on make_lsn_lease failure; fix py fstring format
yliang412 Jun 19, 2024
aabc36f
log warn on lease error; grant lease on all kinds of LSN
yliang412 Jun 19, 2024
fe0fc65
Merge branch 'main' into yuchen/get-lsn-by-ts-leases
yliang412 Jun 19, 2024
169e508
fix test to assert lease granted for all returned LSN kinds
yliang412 Jun 20, 2024
022eecc
Merge branch 'main' into yuchen/get-lsn-by-ts-leases
yliang412 Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pageserver/src/http/routes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,6 +766,9 @@ async fn get_lsn_by_timestamp_handler(
let lease = if with_lease && (kind == "present" || kind == "future") {
timeline
.make_lsn_lease(lsn, timeline.get_lsn_lease_length_for_ts(), &ctx)
.inspect_err(|_| {
info!("fail to grant a lease to {}", lsn);
yliang412 marked this conversation as resolved.
Show resolved Hide resolved
})
.ok()
yliang412 marked this conversation as resolved.
Show resolved Hide resolved
} else {
None
Expand Down
4 changes: 2 additions & 2 deletions test_runner/fixtures/pageserver/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,9 +634,9 @@ def timeline_get_lsn_by_timestamp(
**kwargs,
):
log.info(
f"Requesting lsn by timestamp {timestamp}, tenant {tenant_id}, timeline {timeline_id}, with_lease={with_lease}"
f"Requesting lsn by timestamp {timestamp}, tenant {tenant_id}, timeline {timeline_id}, {with_lease=}"
)
with_lease_query = f"with_lease={with_lease}".lower()
with_lease_query = f"{with_lease=}".lower()
res = self.get(
f"http://localhost:{self.port}/v1/tenant/{tenant_id}/timeline/{timeline_id}/get_lsn_by_timestamp?timestamp={timestamp.isoformat()}Z&{with_lease_query}",
**kwargs,
Expand Down
Loading