Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pageserver): add delta records tests for gc-compaction #8078

Merged
merged 7 commits into from
Jun 24, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jun 17, 2024

Problem

Part of #8002

This pull request adds tests for bottom-most gc-compaction with delta records. Also fixed a bug in the compaction process that creates overlapping delta layers by force splitting at the original delta layer boundary.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from problame June 17, 2024 15:30
@skyzh skyzh requested a review from a team as a code owner June 17, 2024 15:30
Signed-off-by: Alex Chi Z <chi@neon.tech>
Copy link

github-actions bot commented Jun 17, 2024

2941 tests run: 2824 passed, 0 failed, 117 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_pageserver_chaos[None]: release

Code coverage* (full report)

  • functions: 32.6% (6884 of 21137 functions)
  • lines: 50.1% (53672 of 107040 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b139c89 at 2024-06-24T15:55:07.173Z :recycle:

@skyzh skyzh force-pushed the skyzh/legacy-enhanced-gc-delta branch from daea4b1 to b37d988 Compare June 18, 2024 19:42
Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes LGTM

Were the changes in compaction.rs exposed by the added tests?


I don't fully understand why the split point business is necessary. Happy to follow up on this post-merge though.

pageserver/src/tenant.rs Show resolved Hide resolved
pageserver/src/tenant.rs Outdated Show resolved Hide resolved
pageserver/src/tenant.rs Outdated Show resolved Hide resolved
pageserver/src/tenant.rs Outdated Show resolved Hide resolved
pageserver/src/tenant/timeline/compaction.rs Show resolved Hide resolved
pageserver/src/tenant/timeline/compaction.rs Outdated Show resolved Hide resolved
pageserver/src/tenant/timeline/compaction.rs Show resolved Hide resolved
pageserver/src/tenant/timeline/compaction.rs Outdated Show resolved Hide resolved
@skyzh
Copy link
Member Author

skyzh commented Jun 18, 2024

Were the changes in compaction.rs exposed by the added tests?

Yes, the tests reveal some bugs within the compaction algorithm. When it comes to the k-merge re-implementation of that part, we can do a thorough review.

Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh enabled auto-merge (squash) June 24, 2024 14:53
@skyzh skyzh merged commit 9211de0 into main Jun 24, 2024
63 checks passed
@skyzh skyzh deleted the skyzh/legacy-enhanced-gc-delta branch June 24, 2024 15:50
conradludgate pushed a commit that referenced this pull request Jun 27, 2024
Part of #8002

This pull request adds tests for bottom-most gc-compaction with delta
records. Also fixed a bug in the compaction process that creates
overlapping delta layers by force splitting at the original delta layer
boundary.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants