proxy: update tokio-postgres to allow arbitrary config params #8076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
2916 tests run: 2799 passed, 0 failed, 117 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
a284b36 at 2024-06-24T10:21:42.863Z :recycle: |
conradludgate
force-pushed
the
proxy-pg-config-changes
branch
from
d2a6cd1
to
a284b36
Compare
khanova
approved these changes
Jun 24, 2024
|
Nice to see this long-standing issue fixed!
This is only in our fork of tokio-postgres, right? Any plans to submit a PR to upstream? |
The fork has diverted massively at this point. I've struggled to even update the repo from upstream. I see it more likely that we should hard fork and start fresh for all the features proxy needs. |
hlinnaka
added a commit
that referenced
this pull request
Sep 7, 2024
We modified the crate in an incompatible way and upgraded to the new version in PR #8076. However, it was reverted in #8654. The revert reverted the Cargo.lock reference to it, but since Cargo.toml still points to the (tip of the) 'neon' branch, every time you make any other unrealted changes to Cargo.toml, it also tries to update the rust-postgres crates to the tip of the 'neon' branch again, which doesn't work.
hlinnaka
added a commit
that referenced
this pull request
Sep 7, 2024
We modified the crate in an incompatible way and upgraded to the new version in PR #8076. However, it was reverted in #8654. The revert reverted the Cargo.lock reference to it, but since Cargo.toml still points to the (tip of the) 'neon' branch, every time you make any other unrelated changes to Cargo.toml, it also tries to update the rust-postgres crates to the tip of the 'neon' branch again, which doesn't work. To fix, lock the crates to the exact commit SHA that works.
hlinnaka
added a commit
that referenced
this pull request
Sep 7, 2024
We modified the crate in an incompatible way and upgraded to the new version in PR #8076. However, it was reverted in #8654. The revert reverted the Cargo.lock reference to it, but since Cargo.toml still points to the (tip of the) 'neon' branch, every time you make any other unrelated changes to Cargo.toml, it also tries to update the rust-postgres crates to the tip of the 'neon' branch again, which doesn't work. To fix, lock the crates to the exact commit SHA that works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #1287
Summary of changes
tokio-postgres now supports arbitrary server params through the
param(key, value)method. Some keys are special so we explicitly filter them out.Checklist before requesting a review
Checklist before merging