Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pageserver): add delta layer iterator #8064

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jun 14, 2024

Problem

part of #8002

Summary of changes

Add delta layer iterator and tests.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Jun 14, 2024

2940 tests run: 2824 passed, 0 failed, 116 skipped (full report)


Flaky tests (4)

Postgres 16

  • test_lr_with_slow_safekeeper: release

Postgres 14

Code coverage* (full report)

  • functions: 32.7% (6913 of 21143 functions)
  • lines: 50.1% (54092 of 108061 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
9a901a5 at 2024-06-27T16:12:04.743Z :recycle:

Base automatically changed from skyzh/image-layer-iter to main June 25, 2024 20:49
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh marked this pull request as ready for review June 26, 2024 14:47
@skyzh skyzh requested a review from a team as a code owner June 26, 2024 14:47
@skyzh skyzh requested review from VladLazar and problame June 26, 2024 14:47
Signed-off-by: Alex Chi Z <chi@neon.tech>
Copy link
Contributor

@VladLazar VladLazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

libs/utils/src/lsn.rs Outdated Show resolved Hide resolved
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh enabled auto-merge (squash) June 27, 2024 15:45
@skyzh skyzh merged commit 23827c6 into main Jun 27, 2024
56 of 57 checks passed
@skyzh skyzh deleted the skyzh/delta-layer-iter branch June 27, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants